Messages in this thread |  | | | Date | Wed, 6 Jun 2012 13:20:34 -0400 | | Subject | Re: [PATCH 1/1] block/nbd: micro-optimization in nbd request completion | | From | Paul Clements <> |
| |
Makes sense. Looks good to me.
Acked-by: Paul.Clements@steeleye.com
On Wed, Jun 6, 2012 at 10:15 AM, Chetan Loke <loke.chetan@gmail.com> wrote: > > Add in-flight cmds to the tail. That way while searching(during request completion),we will always get a hit on the first element. > > > Signed-off-by: Chetan Loke <loke.chetan@gmail.com> > --- > drivers/block/nbd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > index 061427a..8957b9f 100644 > --- a/drivers/block/nbd.c > +++ b/drivers/block/nbd.c > @@ -481,7 +481,7 @@ static void nbd_handle_req(struct nbd_device *nbd, struct request *req) > nbd_end_request(req); > } else { > spin_lock(&nbd->queue_lock); > - list_add(&req->queuelist, &nbd->queue_head); > + list_add_tail(&req->queuelist, &nbd->queue_head); > spin_unlock(&nbd->queue_lock); > } > > -- > 1.7.5.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |