Messages in this thread Patch in this message | | | From | Roland Dreier <> | Subject | [PATCH 2/2] btree: Catch NULL value before it does harm | Date | Wed, 6 Jun 2012 10:17:27 -0700 |
| |
From: Joern Engel <joern@logfs.org>
Storing NULL values in the btree is illegal and can lead to memory corruption and possible other fun as well. Catch it on insert, instead of waiting for the inevitable.
Signed-off-by: Joern Engel <joern@logfs.org> Signed-off-by: Roland Dreier <roland@purestorage.com> --- lib/btree.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/btree.c b/lib/btree.c index b6e889b..bd6d4b4 100644 --- a/lib/btree.c +++ b/lib/btree.c @@ -509,6 +509,7 @@ retry: int btree_insert(struct btree_head *head, struct btree_geo *geo, unsigned long *key, void *val, gfp_t gfp) { + BUG_ON(!val); return btree_insert_level(head, geo, key, val, 1, gfp); } EXPORT_SYMBOL_GPL(btree_insert); -- 1.7.9.5
| |