Messages in this thread |  | | | Date | Wed, 6 Jun 2012 12:55:53 -0400 (EDT) | | From | Alan Stern <> | | Subject | Re: [PATCH] fix usb skeleton driver |
| |
On Wed, 6 Jun 2012 stefani@seibold.net wrote:
> From: Stefani Seibold <stefani@seibold.net> > > This is a fix for the USB skeleton driver to bring it in shape. > > - The usb_interface structure pointer will be no longer stored > - Every access to the USB will be handled trought the usb_interface pointer
Those two changes sound contradictory.
> - Add a new bool 'connected' for signaling a disconnect (== false) > - Handle a non blocking read without blocking > - Code cleanup > - Synchronize disconnect() handler with open() and release(), to fix races > - Introduced fsync > - Single user mode > - Eliminated dead code > - Save some bytes in the dev structure
How about simplifying the code so that it can be read by somebody who's not already an expert?
Alan Stern
|  |