Messages in this thread | | | Date | Wed, 6 Jun 2012 07:14:19 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH 3/5] perf, x86: Check LBR format capability |
| |
On Wed, Jun 06, 2012 at 12:40:24PM +0200, Peter Zijlstra wrote: > On Tue, 2012-06-05 at 17:56 -0700, Andi Kleen wrote: > > From: Andi Kleen <ak@linux.intel.com> > > > > Double check the CPU has a LBR format we support before using it. > > > > Also I made the init functions __init while I was on it. > > Why? Its all after a model test anyway.
Because the spec says we should check it.
It could catch bad VMs and other inconsistencies and it's the right thing to do.
-Andi
-- ak@linux.intel.com -- Speaking for myself only
| |