Messages in this thread | | | Date | Tue, 05 Jun 2012 15:20:58 -0700 (PDT) | Subject | Re: [PATCH] powerpc: Fix assmption of end_of_DRAM() returns end address | From | David Miller <> |
| |
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: Wed, 06 Jun 2012 08:17:39 +1000
> On Tue, 2012-06-05 at 19:25 +0530, Bharat Bhushan wrote: >> memblock_end_of_DRAM() returns end_address + 1, not end address. >> While some code assumes that it returns end address. > > Shouldn't we instead fix it the other way around ? IE, make > memblock_end_of_DRAM() does what the name implies, which is to return > the last byte of DRAM, and fix the -other- callers not to make bad > assumptions ?
That was my impression too when I saw this patch.
| |