lkml.org 
[lkml]   [2012]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:smp/hotplug] mn10300: SMP: Remove call to ipi_call_lock()/ ipi_call_unlock()
    Commit-ID:  4cbd19fcf9d49f28766415b96eb6201bc263d817
    Gitweb: http://git.kernel.org/tip/4cbd19fcf9d49f28766415b96eb6201bc263d817
    Author: Yong Zhang <yong.zhang0@gmail.com>
    AuthorDate: Tue, 29 May 2012 15:15:57 +0800
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Tue, 5 Jun 2012 17:27:12 +0200

    mn10300: SMP: Remove call to ipi_call_lock()/ipi_call_unlock()

    ipi_call_lock/unlock() lock resp. unlock call_function.lock. This lock
    protects only the call_function data structure itself, but it's
    completely unrelated to cpu_online_mask. The mask to which the IPIs
    are sent is calculated before call_function.lock is taken in
    smp_call_function_many(), so the locking around set_cpu_online() is
    pointless and can be removed.

    [ tglx: Massaged changelog ]

    Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
    Cc: ralf@linux-mips.org
    Cc: sshtylyov@mvista.com
    Cc: david.daney@cavium.com
    Cc: nikunj@linux.vnet.ibm.com
    Cc: paulmck@linux.vnet.ibm.com
    Cc: axboe@kernel.dk
    Cc: peterz@infradead.org
    Cc: David Howells <dhowells@redhat.com>
    Cc: Koichi Yasutake <yasutake.koichi@jp.panasonic.com>
    Cc: linux-am33-list@redhat.com
    Link: http://lkml.kernel.org/r/1338275765-3217-3-git-send-email-yong.zhang0@gmail.com
    Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
    Acked-by: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    ---
    arch/mn10300/kernel/smp.c | 2 --
    1 files changed, 0 insertions(+), 2 deletions(-)

    diff --git a/arch/mn10300/kernel/smp.c b/arch/mn10300/kernel/smp.c
    index 090d35d..e62c223 100644
    --- a/arch/mn10300/kernel/smp.c
    +++ b/arch/mn10300/kernel/smp.c
    @@ -876,9 +876,7 @@ static void __init smp_online(void)

    notify_cpu_starting(cpu);

    - ipi_call_lock();
    set_cpu_online(cpu, true);
    - ipi_call_unlock();

    local_irq_enable();
    }

    \
     
     \ /
      Last update: 2012-06-05 18:41    [W:0.025 / U:1.372 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site