Messages in this thread | | | Date | Tue, 05 Jun 2012 09:17:51 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 2/2] mtip32xx: Create debugfs entries for troubleshooting |
| |
On 06/04/2012 09:44 PM, Asai Thambi S P wrote: > @@ -4062,10 +4210,20 @@ static int __init mtip_init(void) > } > mtip_major = error; > > + if (!dfs_parent) { > + dfs_parent = debugfs_create_dir("rssd", NULL); > + if (IS_ERR_OR_NULL(dfs_parent)) { > + printk(KERN_WARNING "Error creating debugfs parent\n"); > + dfs_parent = NULL; > + } > + } > +
Why would dfs_parent ever be non-NULL here?
Apart from that, looks fine.
-- Jens Axboe
| |