lkml.org 
[lkml]   [2012]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:smp/hotplug] hexagon: SMP: Remove call to ipi_call_lock()/ ipi_call_unlock()
    Commit-ID:  4ee0444bebf3d0399c93841d98826ade193e6330
    Gitweb: http://git.kernel.org/tip/4ee0444bebf3d0399c93841d98826ade193e6330
    Author: Yong Zhang <yong.zhang0@gmail.com>
    AuthorDate: Tue, 29 May 2012 15:15:56 +0800
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Tue, 5 Jun 2012 17:27:11 +0200

    hexagon: SMP: Remove call to ipi_call_lock()/ipi_call_unlock()

    ipi_call_lock/unlock() lock resp. unlock call_function.lock. This lock
    protects only the call_function data structure itself, but it's
    completely unrelated to cpu_online_mask. The mask to which the IPIs
    are sent is calculated before call_function.lock is taken in
    smp_call_function_many(), so the locking around set_cpu_online() is
    pointless and can be removed.

    [ tglx: Massaged changelog ]

    Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
    Cc: ralf@linux-mips.org
    Cc: sshtylyov@mvista.com
    Cc: david.daney@cavium.com
    Cc: nikunj@linux.vnet.ibm.com
    Cc: paulmck@linux.vnet.ibm.com
    Cc: axboe@kernel.dk
    Cc: Richard Kuo <rkuo@codeaurora.org>
    Cc: linux-hexagon@vger.kernel.org
    Link: http://lkml.kernel.org/r/1338275765-3217-2-git-send-email-yong.zhang0@gmail.com
    Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
    Acked-by: Peter Zijlstra <peterz@infradead.org>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    ---
    arch/hexagon/kernel/smp.c | 2 --
    1 files changed, 0 insertions(+), 2 deletions(-)

    diff --git a/arch/hexagon/kernel/smp.c b/arch/hexagon/kernel/smp.c
    index f726462..149fbef 100644
    --- a/arch/hexagon/kernel/smp.c
    +++ b/arch/hexagon/kernel/smp.c
    @@ -180,9 +180,7 @@ void __cpuinit start_secondary(void)

    notify_cpu_starting(cpu);

    - ipi_call_lock();
    set_cpu_online(cpu, true);
    - ipi_call_unlock();

    local_irq_enable();


    \
     
     \ /
      Last update: 2012-06-05 18:01    [W:0.031 / U:90.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site