Messages in this thread | | | Date | Tue, 5 Jun 2012 14:57:58 +0200 | From | Borislav Petkov <> | Subject | Re: [patch 2/2] x86: mce: Implement cmci poll mode for intel machines |
| |
On Tue, Jun 05, 2012 at 07:47:20PM +0800, Chen Gong wrote: > > static void intel_threshold_interrupt(void) > > { > > + if (cmci_storm_detect()) > > + return; > > machine_check_poll(MCP_TIMESTAMP, &__get_cpu_var(mce_banks_owned)); > > mce_notify_irq(); > > } > > I think cmci_storm_detect should be placed in the machine_check_poll, > not out of it. Because machine_check_poll it the core execution logic > for CMCI handling, in the meanwhile, poll timer and mce-inject module > call machine_check_poll at any time.
Are you saying you need CMCI throttling for when you inject MCEs?
> If poll timer or mce-inject run too quickly, the CMCI handler has > trouble. Whereas, if cmci_storm_detect is in the machine_check_poll, > this kind of possibility can be avoid.
In any case, cmci_storm_detect() cannot be in machine_check_poll because last one is generic MCE code and not Intel-only. Unless you do something like what Thomas proposed for mce_adjust_timer where the default function does nothing and Intel only overwrites that pointer with the needed functionality.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |