Messages in this thread |  | | | Date | Mon, 4 Jun 2012 23:37:35 +0200 | | From | Fabio Baltieri <> | | Subject | Re: [PATCH v2 1/3] leds: add oneshot blink functions |
| |
On Fri, Jun 01, 2012 at 09:39:40AM -0600, Shuah Khan wrote: > > > > > There should be no compatibity issues with current timer-trigger calls, > > can you be more specific? > > My initial thought was that maybe you could create new namespace for > this trigger instead of using delay_on and delay_off. However, after > looking closely at the patch set you are proposing, since you are using > delay_on and delay_off in led_cdev, I think you are ok.
Ok, the patch should integrate pretty well with existing software-timer code, and delay_{on,off} retains the same meaning. > Please make sure there is no regression in the ledtrig-timer use-cases, > with the changes made to led-class and led-core.
Of course, I've made many tests with mixes of led_trigger_blink() and led_trigger_blink_oneshot() calls, and they seems to work samelessly. Did you have any chance to test it?
If you think that the patch is good I'd like to consider that for integration, so I can repost a modified version of my can-trigger patch on the linux-can mailing list.
Fabio
|  |