lkml.org 
[lkml]   [2012]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH v2 5/7] KVM: Introduce PV kick in flush tlb
From
Date
In place of looping continuously introduce a halt if we do not succeed
after some time.

For vcpus that were running an IPI is sent. In case, it went to sleep
between this, we will be doing flush_on_enter(harmless). But as a
flush IPI was already sent, that will be processed in ipi handler,
this might result into something undesireable, i.e. It might clear the
flush_mask of a new request.

So after sending an IPI and waiting for a while, do a halt and wait
for a kick from the last vcpu.

Signed-off-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Signed-off-by: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
---
arch/x86/mm/tlb.c | 25 +++++++++++++++++--------
1 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index f5dacdd..2c686bf 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -43,6 +43,8 @@ union smp_flush_state {
struct {
struct mm_struct *flush_mm;
unsigned long flush_va;
+ int sender_cpu;
+ unsigned int need_kick;
raw_spinlock_t tlbstate_lock;
DECLARE_BITMAP(flush_cpumask, NR_CPUS);
};
@@ -167,6 +169,11 @@ out:
smp_mb__before_clear_bit();
cpumask_clear_cpu(cpu, to_cpumask(f->flush_cpumask));
smp_mb__after_clear_bit();
+ if (f->need_kick && cpumask_empty(to_cpumask(f->flush_cpumask))) {
+ f->need_kick = 0;
+ smp_wmb();
+ kvm_kick_cpu(f->sender_cpu);
+ }
inc_irq_stat(irq_tlb_count);
}

@@ -222,15 +229,17 @@ void kvm_flush_tlb_others(const struct cpumask *cpumask,
if (nr_cpu_ids > NUM_INVALIDATE_TLB_VECTORS)
raw_spin_lock(&f->tlbstate_lock);

+ cpu = smp_processor_id();
f->flush_mm = mm;
f->flush_va = va;
- if (cpumask_andnot(to_cpumask(f->flush_cpumask), cpumask, cpumask_of(smp_processor_id()))) {
+ f->sender_cpu = cpu;
+ f->need_kick = 0;
+ if (cpumask_andnot(to_cpumask(f->flush_cpumask), cpumask, cpumask_of(cpu))) {
/*
* We have to send the IPI only to online vCPUs
* affected. And queue flush_on_enter for pre-empted
* vCPUs
*/
-again:
for_each_cpu(cpu, to_cpumask(f->flush_cpumask)) {
v_state = &per_cpu(vcpu_state, cpu);

@@ -242,9 +251,6 @@ again:
}
}

- if (cpumask_empty(to_cpumask(f->flush_cpumask)))
- goto out;
-
apic->send_IPI_mask(to_cpumask(f->flush_cpumask),
INVALIDATE_TLB_VECTOR_START + sender);

@@ -252,10 +258,13 @@ again:
while (!cpumask_empty(to_cpumask(f->flush_cpumask)) && --loop)
cpu_relax();

- if (!cpumask_empty(to_cpumask(f->flush_cpumask)))
- goto again;
+ if (!loop) {
+ f->need_kick = 1;
+ smp_mb();
+ while (!cpumask_empty(to_cpumask(f->flush_cpumask)))
+ halt();
+ }
}
-out:
f->flush_mm = NULL;
f->flush_va = 0;
if (nr_cpu_ids > NUM_INVALIDATE_TLB_VECTORS)


\
 
 \ /
  Last update: 2012-06-04 07:42    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site