lkml.org 
[lkml]   [2012]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] ohci-nxp: Use ohci_finish_controller_resume()
    From
    Hi,

    On Sun, Jun 3, 2012 at 11:54 PM, Roland Stigge <stigge@antcom.de> wrote:
    > OHCI drivers are supposed to use ohci_finish_controller_resume(). This patch
    > adds respective suspend and resume code to ohci-nxp. The following compiler
    > warning is fixed this way:
    >
    > drivers/usb/host/ohci-hub.c:321: warning: 'ohci_finish_controller_resume'
    > defined but not used
    >
    > Signed-off-by: Roland Stigge <stigge@antcom.de>
    >
    > ---
    > Applies to v3.5-rc1
    >
    >  drivers/usb/host/ohci-nxp.c |   21 +++++++++++++++++++++
    >  1 file changed, 21 insertions(+)
    >
    > --- linux-2.6.orig/drivers/usb/host/ohci-nxp.c
    > +++ linux-2.6/drivers/usb/host/ohci-nxp.c
    > @@ -432,6 +432,23 @@ static int usb_hcd_nxp_remove(struct pla
    >        return 0;
    >  }
    >
    > +#ifdef CONFIG_PM
    > +static int usb_hcd_suspend(struct platform_device *pdev, pm_message_t message)
    > +{
    > +       clk_disable(usb_clk);
    > +       return 0;
    > +}
    > +
    > +static int usb_hcd_resume(struct platform_device *pdev)
    > +{
    > +       struct usb_hcd *hcd = platform_get_drvdata(pdev);
    > +
    > +       clk_enable(usb_clk);
    > +       ohci_finish_controller_resume(hcd);
    > +       return 0;
    > +}
    > +#endif
    > +
    >  /* work with hotplug and coldplug */
    >  MODULE_ALIAS("platform:usb-ohci");
    >
    > @@ -451,5 +468,9 @@ static struct platform_driver usb_hcd_nx
    >        },
    >        .probe = usb_hcd_nxp_probe,
    >        .remove = usb_hcd_nxp_remove,
    > +#ifdef CONFIG_PM
    > +       .suspend = usb_hcd_suspend,
    > +       .resume = usb_hcd_resume,
    > +#endif

    Please make use of the SET_SYSTEM_SLEEP_PM_OPS() initializer.

    Thanks
    Kishon
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-06-04 17:21    [W:0.026 / U:63.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site