lkml.org 
[lkml]   [2012]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched: balance_cpu to consider other cpus in its group as target of (pinned) task migration
* Peter Zijlstra <peterz@infradead.org> [2012-06-04 11:00:54]:

> > Signed-off-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
>
> Did vatsa write this patch?

I wrote the first version of the patch which Prashanth took, tested,
fixed a bug and is finally publishing it. So yes,

> If so, you forgot a From header, if not, wtf!?

it is missing the From header.

> OK, so previously we only pulled to ourselves,

That't not entirely true isn't it i.e this_cpu need not equal
smp_processor_id even before this change.

> now you make cpu x move
> from cpu y to cpu z. This changes the dynamic of the load-balancer, not
> a single word on that and its impact/ramifications.

The other possibility is for the right sibling cpus to do load balance
in the same domain (noting that it needs to pull a task from another
sched_group to itself and ignoring balance_cpu). That seemed like a more
invasive change than this patch. We'd be happy to try any other approach
you have in mind.

- vatsa



\
 
 \ /
  Last update: 2012-06-04 15:44    [W:0.068 / U:4.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site