lkml.org 
[lkml]   [2012]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC 3/6] remoteproc: Move fw sanity check to find_rsc_table.
    On Mon, Jun 4, 2012 at 12:56 PM, Sjur BRENDELAND
    <sjur.brandeland@stericsson.com> wrote:
    > The sanity_check() is working on the ELF structures. And all ELF
    > processing needs to be moved to a separate file. So if you want
    > to keep the call to sanity_check() here, I need to make the
    > sanity_check() function a separate handler. That could make sense,
    > but will also bloat the struct rproc_fw_ops with one more function
    > pointer.

    I think it's OK.

    Adding another handler is cheap, and if by doing so the code becomes
    even slightly easier to read or maintain, it's probably worth it.

    Thanks,
    Ohad.


    \
     
     \ /
      Last update: 2012-06-04 13:01    [W:3.180 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site