lkml.org 
[lkml]   [2012]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] regulator: max77686: Fix checkpatch warnings
    From
    Date
    Fix below checkpatch warnings:

    $ scripts/checkpatch.pl -f drivers/regulator/max77686.c
    ERROR: return is not a function, parentheses are not required
    + return (DIV_ROUND_UP(rdev->desc->uV_step

    WARNING: line over 80 characters
    + .ops = &max77686_buck_dvs_ops, \

    total: 1 errors, 1 warnings, 339 lines checked

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    ---
    drivers/regulator/max77686.c | 9 +++++----
    1 file changed, 5 insertions(+), 4 deletions(-)

    diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c
    index 4e9f4f3..0815de1 100644
    --- a/drivers/regulator/max77686.c
    +++ b/drivers/regulator/max77686.c
    @@ -75,9 +75,10 @@ static int max77686_set_dvs_voltage_time_sel(struct regulator_dev *rdev,
    {
    struct max77686_data *max77686 = rdev_get_drvdata(rdev);
    int ramp_rate[] = {13, 27, 55, 100};
    - return (DIV_ROUND_UP(rdev->desc->uV_step
    - * abs(new_selector - old_selector),
    - ramp_rate[max77686->ramp_delay]));
    +
    + return DIV_ROUND_UP(rdev->desc->uV_step *
    + abs(new_selector - old_selector),
    + ramp_rate[max77686->ramp_delay]);
    }

    static int max77686_set_voltage_time_sel(struct regulator_dev *rdev,
    @@ -171,7 +172,7 @@ static struct regulator_ops max77686_buck_dvs_ops = {
    #define regulator_desc_buck_dvs(num) { \
    .name = "BUCK"#num, \
    .id = MAX77686_BUCK##num, \
    - .ops = &max77686_buck_dvs_ops, \
    + .ops = &max77686_buck_dvs_ops, \
    .type = REGULATOR_VOLTAGE, \
    .owner = THIS_MODULE, \
    .min_uV = MAX77686_DVS_MINUV, \
    --
    1.7.9.5




    \
     
     \ /
      Last update: 2012-06-04 04:41    [W:0.023 / U:14.352 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site