Messages in this thread | | | From | Heiko Stübner <> | Subject | [PATCH 0/3] regulator: gpio-regulator: Fixes for problems that turned up with 3.5-rc1 | Date | Sun, 3 Jun 2012 21:29:45 +0200 |
| |
During the porting of my machine to 3.5-rc1 some glitches in the gpio-regulator from different changes popped up.
This series fixes these.
While doing this, I noticed a possible uninitialized use of "selector" in _regulator_do_set_voltage, where I'm not sure what the correct fix would be.
To summarize, before if (rdev->desc->ops->list_voltage) best_val = rdev->desc->ops->list_voltage(rdev, selector); else best_val = -1;
selector is set in the set_voltage callback or if the new map_voltage returns a non-error value. If it returns an error value or the else clause is reached selector is used uninitialized in the list_voltage and set_voltage_time_sel call.
As written above, I'm not sure what the correct fix would be here.
Heiko Stuebner (3): regulator: gpio-regulator: do not pass drvdata pointer as reference regulator: gpio-regulator: Fix finding of smallest value regulator: gpio-regulator: populate selector from set_voltage
drivers/regulator/gpio-regulator.c | 16 ++++++++++------ 1 files changed, 10 insertions(+), 6 deletions(-)
-- 1.7.2.3
| |