Messages in this thread | | | Date | Fri, 29 Jun 2012 13:20:35 +0200 | From | Richard Weinberger <> | Subject | Re: [PATCH] ubi: fastmap: Do not free 'ai' in 'scan_all()' |
| |
Am Thu, 28 Jun 2012 17:45:46 +0300 schrieb Shmulik Ladkani <shmulik.ladkani@gmail.com>:
> From: Shmulik Ladkani <shmulik.ladkani@gmail.com> > > Do not call 'destroy_ai(ai)' at error handling of 'scan_all', since: > - 'ai' is allocated in 'ubi_attach' (the caller of scan_all) and > provided as an argument. It's not scan_all's responsibility to free > it > - It is not consistent with scan_all's sister function > 'ubi_attach_fastmap()' which does not free the given 'ai' > - It will cause a double free as 'ubi_attach' (the caller of scan_all) > already destroys 'ai' in case of an error > > Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com> > ---
Applied!
Thanks, //richard
| |