[lkml]   [2012]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] KSM: numa awareness sysfs knob
On Fri, 29 Jun 2012, Johannes Weiner wrote:

> > I started with exactly same idea as you described above in the first
> > RFC, link:
> > But this approach turned out to be more complicated than it looked
> > (see two last emails in thread) and complexity of solution would rise
> > a lot.
> Oh, I should have checked the archives given that it's v2. I expected
> it to get complex but didn't put enough thought into it to see /that/
> amount of complexity. Sorry.
> Carry on, then :-)

I don't think it's an unfair amount of complexity to ask for, and I don't
see the problem with ksm merging two pages that have a distance under the
configured threshold and leaving the third page unmerged; by configuring
the threshold (which should be a char, not an int) the admin has specified
the locality that is necessary for optimal performance so has knowingly
restricted ksm in that way.

I'd rename it to ksm_merge_distance, which is more similar to
reclaim_distance, and return to the first version of this patch.

 \ /
  Last update: 2012-06-30 01:01    [W:0.063 / U:38.524 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site