Messages in this thread | | | Date | Fri, 29 Jun 2012 09:50:41 +0200 | From | Éric Piel <> | Subject | Re: [PATCH 08/12] hp_accel: convert to module_acpi_driver() |
| |
On 28-06-12 12:59, Mika Westerberg wrote: > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Hello, Looks fine from my point of view.
Reviewed-by: Éric Piel <eric.piel@tremplin-utc.net>
Éric
> --- > drivers/platform/x86/hp_accel.c | 25 +------------------------ > 1 file changed, 1 insertion(+), 24 deletions(-) > > diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c > index 22b2dfa..7246e66 100644 > --- a/drivers/platform/x86/hp_accel.c > +++ b/drivers/platform/x86/hp_accel.c > @@ -381,31 +381,8 @@ static struct acpi_driver lis3lv02d_driver = { > .resume = lis3lv02d_resume, > } > }; > - > -static int __init lis3lv02d_init_module(void) > -{ > - int ret; > - > - if (acpi_disabled) > - return -ENODEV; > - > - ret = acpi_bus_register_driver(&lis3lv02d_driver); > - if (ret < 0) > - return ret; > - > - pr_info("driver loaded\n"); > - > - return 0; > -} > - > -static void __exit lis3lv02d_exit_module(void) > -{ > - acpi_bus_unregister_driver(&lis3lv02d_driver); > -} > +module_acpi_driver(lis3lv02d_driver); > > MODULE_DESCRIPTION("Glue between LIS3LV02Dx and HP ACPI BIOS and support for disk protection LED."); > MODULE_AUTHOR("Yan Burman, Eric Piel, Pavel Machek"); > MODULE_LICENSE("GPL"); > - > -module_init(lis3lv02d_init_module); > -module_exit(lis3lv02d_exit_module); >
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |