Messages in this thread | | | Subject | Re: [PATCH] fat: Refactor shortname parsing | From | "Steven J. Magnani" <> | Date | Fri, 29 Jun 2012 14:13:55 -0500 |
| |
On Sat, 2012-06-30 at 04:08 +0900, OGAWA Hirofumi wrote: > "Steven J. Magnani" <steve@digidescorp.com> writes: > > > Nearly identical shortname parsing is performed in fat_search_long() > > and __fat_readdir(). Extract this code into a function that may be > > called by both. > > What is the difference, and why changes was needed?
The only difference I could see was in the "dot_hidden" functionality. fat_search_long() never does it; __fat_readdir() does it only when the 'dotsOK' option is active.
The changes are not 'needed'; they are purely to simplify future maintenance of the code.
Regards, Steve
| |