lkml.org 
[lkml]   [2012]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v10] MTD: LPC32xx MLC NAND driver
    From
    On Fri, Jun 29, 2012 at 10:04 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
    > On Fri, 2012-06-29 at 09:56 -0300, Alexandre Pereira da Silva wrote:
    >> > @@ @@
    >> > +drivers/mtd/nand/lpc32xx_mlc.c: In function 'lpc32xx_nand_probe':
    >> > +drivers/mtd/nand/lpc32xx_mlc.c:679:10: warning: variable 'sr' set but not used [-Wunused-but-set-variable]
    >
    > gcc 4.6, aiaiai uses W=1 when building.
    >
    >> > +drivers/mtd/nand/lpc32xx_mlc.c:561:24: error: bad constant expression [sparse]
    >
    > This is sparse, not gcc.

    Does the oob area need to be ecc protected? If not I suggest to just
    remove the read_oob and write_oob and let this to nand_base. I think
    this is too much overhead to read 6 bytes.


    \
     
     \ /
      Last update: 2012-06-29 16:01    [W:0.028 / U:0.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site