Messages in this thread Patch in this message | | | Date | Thu, 28 Jun 2012 19:16:26 -0400 | From | Steven Rostedt <> | Subject | [PATCH 1/4] tracing/selftest: Add a WARN_ON() if a tracer test fails |
| |
From: Steven Rostedt <srostedt@redhat.com>
Add a WARN_ON() output on test failures so that they are easier to detect in automated tests. Although, the WARN_ON() will not print if the test causes the system to crash, obviously.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- kernel/trace/trace.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 49249c2..748f640 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -830,6 +830,8 @@ int register_tracer(struct tracer *type) current_trace = saved_tracer; if (ret) { printk(KERN_CONT "FAILED!\n"); + /* Add the warning after printing 'FAILED' */ + WARN_ON(1); goto out; } /* Only reset on passing, to avoid touching corrupted buffers */ -- 1.7.10
[unhandled content-type:application/pgp-signature] | |