Messages in this thread | | | Date | Thu, 28 Jun 2012 17:47:57 +0200 | Subject | Re: [PATCH 01/15] ARM: etm: Don't require clock control | From | Linus Walleij <> |
| |
On Thu, Jun 21, 2012 at 12:47 AM, John Stultz <john.stultz@linaro.org> wrote:
> - clk_enable(t->emu_clk); > + else > + clk_enable(t->emu_clk);
Take this opportunity to use clk_prepare_enable();
> etb_unlock(t); > t->etb_bufsz = etb_readl(t, ETBR_DEPTH); > @@ -403,8 +402,10 @@ static int etb_remove(struct amba_device *dev) > iounmap(t->etb_regs); > t->etb_regs = NULL; > > - clk_disable(t->emu_clk); > - clk_put(t->emu_clk); > + if (!IS_ERR(t->emu_clk)) { > + clk_disable(t->emu_clk);
And clk_disable_uprepare() here.
> + clk_put(t->emu_clk); > + }
After that it's Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |