lkml.org 
[lkml]   [2012]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/6] kvm: Extend irqfd to support level interrupts
On 06/28/2012 12:19 AM, Alex Williamson wrote:
>> > @@ -302,6 +385,7 @@ kvm_irqfd_deassign(struct kvm *kvm, struct kvm_irqfd *args)
>> > {
>> > struct _irqfd *irqfd, *tmp;
>> > struct eventfd_ctx *eventfd;
>> > + bool is_level = (args->flags & KVM_IRQFD_FLAG_LEVEL) != 0;
>>
>> != 0 is not needed here I think.
>
> Strictly, no it's not. I just prefer to set bools from bools and I
> think Avi has commented on using !! before.

I prefer the naked version too, but != 0 is acceptable.
--
error compiling committee.c: too many arguments to function




\
 
 \ /
  Last update: 2012-06-28 15:21    [W:0.100 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site