Messages in this thread | | | Date | Thu, 28 Jun 2012 15:41:33 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH v2 4/6] kvm: Extend irqfd to support level interrupts |
| |
On 06/28/2012 12:19 AM, Alex Williamson wrote: >> > @@ -302,6 +385,7 @@ kvm_irqfd_deassign(struct kvm *kvm, struct kvm_irqfd *args) >> > { >> > struct _irqfd *irqfd, *tmp; >> > struct eventfd_ctx *eventfd; >> > + bool is_level = (args->flags & KVM_IRQFD_FLAG_LEVEL) != 0; >> >> != 0 is not needed here I think. > > Strictly, no it's not. I just prefer to set bools from bools and I > think Avi has commented on using !! before.
I prefer the naked version too, but != 0 is acceptable. -- error compiling committee.c: too many arguments to function
| |