Messages in this thread | | | Date | Wed, 27 Jun 2012 09:32:57 +0200 | Subject | Re: [PATCH 04/12] frv: remove km_type definitions | From | Geert Uytterhoeven <> |
| |
On Wed, Jun 27, 2012 at 5:24 AM, Cong Wang <amwang@redhat.com> wrote: > On Tue, 2012-06-26 at 22:25 +0200, Geert Uytterhoeven wrote: >> >> "enum km_type" and "__KM_CACHE" are still used in >> arch/frv/include/asm/highmem.h: > > Oops! I missed __KM_* types... Fortunately, the following patch could > probably fix it. > > Thanks! > > -----------------------> > > All callers of kmap_atomic_primary() use __KM_CACHE, so it can be > removed safely, and __kmap_atomic_primary() only check if 'type' if
s/if$/is/
> __KM_CACHE or not, so 'type' can be changed to a boolean as well. > > Ditto for kunmap_atomic_primary()/__kunmap_atomic_primary().
Looks OK to me (don't have the hardware). Thx!
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |