lkml.org 
[lkml]   [2012]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/16] UBI: Fastmap: Address jet another TOOD
    Date
    Writing the fastmap upon attach time if ai->is_empty=1
    does not make sense. At this stage the erase worker is busy
    with erasing all PEBs and fastmap won't get a free anchor PEB.
    While detaching we write anyway a fastmap.

    Signed-off-by: Richard Weinberger <richard@nod.at>
    ---
    drivers/mtd/ubi/attach.c | 8 --------
    1 files changed, 0 insertions(+), 8 deletions(-)

    diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c
    index 021c7d3..068f11a 100644
    --- a/drivers/mtd/ubi/attach.c
    +++ b/drivers/mtd/ubi/attach.c
    @@ -1301,14 +1301,6 @@ int ubi_attach(struct ubi_device *ubi, int force_scan)
    }

    destroy_ai(ubi, ai);
    -
    - /* TODO: UBI auto formats the flash if it is empty (see ubi->is_empty).
    - * It is currently done so that every sub-system writes initializes its
    - * own stuff. Well, now it is only the vtbl sub-system - it creates
    - * empty volume table. And this is why we have "early" function for
    - * getting free PEBs. Fastmap should do the same - so I guess it is
    - * good to do it somewhere here. Also, we need to re-create the fastmap
    - * on-flash data-structures if they were corrupted. */
    return 0;

    out_wl:
    --
    1.7.6.5


    \
     
     \ /
      Last update: 2012-06-27 19:21    [W:0.030 / U:0.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site