lkml.org 
[lkml]   [2012]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [char-misc fix for 3.5] mei: pci_resume: set IRQF_ONESHOT for msi request_threaded_irq
Date
On Wednesday 27 June 2012 17:14:20 Tomas Winkler wrote:
> when the default irq quick handler is used then IRQF_ONESHOT must be set
> otherwise the request fails and following error is displayed:
>
> mei 0000:00:16.0: irq 48 for MSI/MSI-X
> genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 48
> mei 0000:00:16.0: request_threaded_irq failed: irq = 48.
> dpm_run_callback(): pci_pm_resume+0x0/0x140 returns -22
> PM: Device 0000:00:16.0 failed to resume async: error -22
>
> Reported-by: Lekensteyn <lekensteyn@gmail.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Tested-by: Peter Wu <lekensteyn@gmail.com>

(for the real name policy, if you prefer "Lekensteyn", it's fine too)

> ---
> drivers/misc/mei/main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
> index 7de1389..783fcd7 100644
> --- a/drivers/misc/mei/main.c
> +++ b/drivers/misc/mei/main.c
> @@ -1147,7 +1147,7 @@ static int mei_pci_resume(struct device *device)
> err = request_threaded_irq(pdev->irq,
> NULL,
> mei_interrupt_thread_handler,
> - 0, mei_driver_name, dev);
> + IRQF_ONESHOT, mei_driver_name, dev);
> else
> err = request_threaded_irq(pdev->irq,
> mei_interrupt_quick_handler,


\
 
 \ /
  Last update: 2012-06-27 17:41    [from the cache]
©2003-2011 Jasper Spaans