lkml.org 
[lkml]   [2012]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf sched replay: fix event lookup
On 06/26/2012 03:20 AM, Arnaldo Carvalho de Melo wrote:
>
>> Fair enough. The method should be a simple wrapper to libtraceevent APIs
>> like this patch.
>
> The pevent thing is per perf.data file, so I made it stop being static
> and become a perf_session member, so tools processing perf.data files
> use perf_session and _there_ we read the event into session->pevent and
> then have to change everywhere to stop using that single global pevent
> variable and use the per session one.
>
> Dmitry, can you test the attached patch to check if it solves the
> problems you reported?

This looks good and works for my x86 <-> ARM tests.

> Note that it _doesn't_ fall backs to trace__event_id, as we're not
> interested at all in what is present in the
> /sys/kernel/debug/tracing/events in the workstation doing the analysis,
> just in what is in the perf.data file.

Agree.

Dmitry


\
 
 \ /
  Last update: 2012-06-27 12:01    [W:0.677 / U:0.020 seconds]
©2003-2014 Jasper Spaans. Advertise on this site