[lkml]   [2012]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch -resend] 9p: fix min_t() casting in p9pdu_vwritef()
    I don't think we're actually likely to hit this limit but if we do
    then the comparison should be done as size_t. The original code
    is equivalent to:
    len = strlen(sptr) % USHRT_MAX;

    Signed-off-by: Dan Carpenter <>
    I was told this patch "has already made it upstream via the v9fs pull."
    but it must have been dropped accidentally. Originally sent on Sat,
    Jan 15, 2011.

    diff --git a/net/9p/protocol.c b/net/9p/protocol.c
    index 9ee48cb..3d33ecf 100644
    --- a/net/9p/protocol.c
    +++ b/net/9p/protocol.c
    @@ -368,7 +368,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt,
    const char *sptr = va_arg(ap, const char *);
    uint16_t len = 0;
    if (sptr)
    - len = min_t(uint16_t, strlen(sptr),
    + len = min_t(size_t, strlen(sptr),

    errcode = p9pdu_writef(pdu, proto_version,

     \ /
      Last update: 2012-06-27 11:41    [W:0.046 / U:5.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site