Messages in this thread | | | Date | Tue, 26 Jun 2012 18:08:13 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH 00/11] kmem controller for memcg: stripped down version |
| |
On Tue, 26 Jun 2012, Andrew Morton wrote:
> mm, maybe. Kernel developers tend to look at code from the point of > view "does it work as designed", "is it clean", "is it efficient", "do > I understand it", etc. We often forget to step back and really > consider whether or not it should be merged at all. >
It's appropriate for true memory isolation so that applications cannot cause an excess of slab to be consumed. This allows other applications to have higher reservations without the risk of incurring a global oom condition as the result of the usage of other memcgs.
I'm not sure whether it would ever be appropriate to limit the amount of slab for an individual slab cache, however, instead of limiting the sum of all slab for a set of processes. With cache merging in slub this would seem to be difficult to do correctly.
| |