Messages in this thread Patch in this message | | | Date | Wed, 27 Jun 2012 00:55:37 +0200 (CEST) | From | Jesper Juhl <> | Subject | [PATCH] drm/i915/sprite: Fix mem leak in intel_plane_init() |
| |
If we ever hit the default case in the switch statement we'll return from the function without freeing the memory we just allocated to 'intel_plane' (but that has not been used).
This patch gets rid of the leak by freeing the memory just before we return.
Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c index 2a20fb0..c8851ba 100644 --- a/drivers/gpu/drm/i915/intel_sprite.c +++ b/drivers/gpu/drm/i915/intel_sprite.c @@ -685,6 +685,7 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe) break; default: + kfree(intel_plane); return -ENODEV; } @@ -699,4 +700,3 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe) return ret; } - -- 1.7.11.1
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
| |