lkml.org 
[lkml]   [2012]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ipmi: setting OS name as Linux in BMC
On 06/26/2012 11:02 AM, Srinivas_G_Gowda@Dell.com wrote:
> Corey, Thanks for the comments. I was looking at the way BMC presence
> is detected. Thought it would be appropriate that BMC is told about
> the OS information -- Soon after ipmi_si driver detects
> BMC(Get_Device_ID) and before the driver starts doing anything useful.
> Looked like a quick clean getaway..! Looking at the ipmi_msghandler, I
> don't see how we will be able to do this during the driver
> initialization process. I could probably do it inside
> ipmi_register_smi in ipmi_msghandler. But I still prefer doing this in
> ipmi_si itself. Please let me know your thoughts on this. Thanks, G

The trouble is that there are other interfaces (that are unfortunately
not in the mainstream kernel, but that's a different story) that would
not benefit from this if you put it in ipmi_si. That's a low-level
interface, this is a higher-level function and belongs.

Look at get_guid() called from ipmi_register_smi() in
ipmi_msghandler.c. It's not that hard.

-corey


\
 
 \ /
  Last update: 2012-06-26 19:41    [W:3.898 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site