Messages in this thread | | | Date | Tue, 26 Jun 2012 18:52:58 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 1/4] mm: introduce compaction and migration for virtio ballooned pages |
| |
> > What shocked me actually is that VM_BUG_ON code is executed on > !CONFIG_DEBUG_VM builds and has been since 2.6.36 due to commit [4e60c86bd: > gcc-4.6: mm: fix unused but set warnings]. I thought the whole point of > VM_BUG_ON was to avoid expensive and usually unnecessary checks. Andi, > was this deliberate?
The idea was that the compiler optimizes it away anyways.
I'm not fully sure what putback_balloon_page does, but if it just tests a bit (without non variable test_bit) it should be ok.
-Andi
| |