lkml.org 
[lkml]   [2012]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] mm: introduce compaction and migration for virtio ballooned pages
    > 
    > What shocked me actually is that VM_BUG_ON code is executed on
    > !CONFIG_DEBUG_VM builds and has been since 2.6.36 due to commit [4e60c86bd:
    > gcc-4.6: mm: fix unused but set warnings]. I thought the whole point of
    > VM_BUG_ON was to avoid expensive and usually unnecessary checks. Andi,
    > was this deliberate?

    The idea was that the compiler optimizes it away anyways.

    I'm not fully sure what putback_balloon_page does, but if it just tests
    a bit (without non variable test_bit) it should be ok.

    -Andi


    \
     
     \ /
      Last update: 2012-06-26 19:41    [W:0.025 / U:0.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site