Messages in this thread | | | Date | Tue, 26 Jun 2012 17:47:36 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v2 5/5] uprobes: __replace_page() needs munlock_vma_page() |
| |
On 06/26, Anton Arapov wrote: > > On Sun, Jun 24, 2012 at 05:01:11PM +0200, Oleg Nesterov wrote: > > Like do_wp_page(), __replace_page() should do munlock_vma_page() > > for the case when the old page still has other !VM_LOCKED mappings. > > Unfortunately this needs mm/internal.h. > > > > --- a/kernel/events/uprobes.c > > +++ b/kernel/events/uprobes.c > > @@ -32,6 +32,7 @@ > > #include <linux/swap.h> /* try_to_free_swap */ > > #include <linux/ptrace.h> /* user_enable_single_step */ > > #include <linux/kdebug.h> /* notifier mechanism */ > > +#include "../../mm/internal.h" /* munlock_vma_page */ > > We have vma_adress() defined in internal.h, under #ifdef CONFIG_TRANSPARENT_HUGEPAGE . > > NAK. :-)
Damn you Anton ;) You seem to dislike number 5...
OK, please ignore this patch.
Can't resist. I swear, I specially checked mm/internal.h to ensure it doesn't export mm/rmap.c:vma_address(), can't understand how I didn't notice this declaration.
Oleg.
| |