Messages in this thread | | | Date | Mon, 25 Jun 2012 13:49:10 +0530 | From | Rajeev kumar <> | Subject | Re: [PATCH] rtc/rtc-spear: remove unnecessary check against rtc_valid_tm and tm2bcd |
| |
On 6/23/2012 5:13 PM, Devendra Naga wrote: > rtc_valid_tm is always return > -EINVAL if the time doesn't represent a valid date and time and 0 if its. > > so we can simply do rtc_valid_tm(tm) rather doing rtc_valid_tm(tm) != 0 checking. > and also tm2bcd() does return -EINVAL if the time doesn't represent a valid date and time > and 0 if its. > > and also removing err because is_write_complete will return -EIO if our write to the > RTC registers didn't happen and 0 if its. > > Signed-off-by: Devendra Naga<devendra.aaru@gmail.com>
Acked-By: Rajeev Kumar <rajeev-dlh.kumar@st.com>
~Rajeev
| |