lkml.org 
[lkml]   [2012]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] rtc/rtc-spear: remove unnecessary check against rtc_valid_tm and tm2bcd
    On 6/23/2012 5:13 PM, Devendra Naga wrote:
    > rtc_valid_tm is always return
    > -EINVAL if the time doesn't represent a valid date and time and 0 if its.
    >
    > so we can simply do rtc_valid_tm(tm) rather doing rtc_valid_tm(tm) != 0 checking.
    > and also tm2bcd() does return -EINVAL if the time doesn't represent a valid date and time
    > and 0 if its.
    >
    > and also removing err because is_write_complete will return -EIO if our write to the
    > RTC registers didn't happen and 0 if its.
    >
    > Signed-off-by: Devendra Naga<devendra.aaru@gmail.com>

    Acked-By: Rajeev Kumar <rajeev-dlh.kumar@st.com>

    ~Rajeev


    \
     
     \ /
      Last update: 2012-06-25 11:02    [W:0.027 / U:122.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site