lkml.org 
[lkml]   [2012]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] audit: don't free_chunk() after fsnotify_add_mark()
    Date
    From: Miklos Szeredi <mszeredi@suse.cz>

    Don't do free_chunk() after fsnotify_add_mark(). That one does a delayed unref
    via the destroy list and this results in use-after-free.

    Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
    CC: stable@vger.kernel.org
    ---
    kernel/audit_tree.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
    index 5bf0790..d52d247 100644
    --- a/kernel/audit_tree.c
    +++ b/kernel/audit_tree.c
    @@ -259,7 +259,7 @@ static void untag_chunk(struct node *p)

    fsnotify_duplicate_mark(&new->mark, entry);
    if (fsnotify_add_mark(&new->mark, new->mark.group, new->mark.i.inode, NULL, 1)) {
    - free_chunk(new);
    + fsnotify_put_mark(&new->mark);
    goto Fallback;
    }

    @@ -322,7 +322,7 @@ static int create_chunk(struct inode *inode, struct audit_tree *tree)

    entry = &chunk->mark;
    if (fsnotify_add_mark(entry, audit_tree_group, inode, NULL, 0)) {
    - free_chunk(chunk);
    + fsnotify_put_mark(entry);
    return -ENOSPC;
    }

    @@ -396,7 +396,7 @@ static int tag_chunk(struct inode *inode, struct audit_tree *tree)
    fsnotify_duplicate_mark(chunk_entry, old_entry);
    if (fsnotify_add_mark(chunk_entry, chunk_entry->group, chunk_entry->i.inode, NULL, 1)) {
    spin_unlock(&old_entry->lock);
    - free_chunk(chunk);
    + fsnotify_put_mark(chunk_entry);
    fsnotify_put_mark(old_entry);
    return -ENOSPC;
    }
    --
    1.7.7


    \
     
     \ /
      Last update: 2012-06-25 20:21    [W:0.030 / U:0.696 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site