[lkml]   [2012]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] drivers: staging: android: fix binder.c printk macros
    On Mon, 2012-06-25 at 10:24 -0700, Greg KH wrote:
    > On Mon, Jun 25, 2012 at 10:20:00AM -0700, Joe Perches wrote:
    > > Your patch-bot needs work.
    > >
    > > Converting printks to pr_<level> is trivial
    > > and should be done all at once, not piecemeal.
    > I'm not disagreeing with that, unfortunately this patch also did more
    > than just pr_<level> conversions, which is why my patch-bot kicked in.
    > So your patch-bot complaint generator needs work :)

    Or not. I think wholesale whitespace changes are just
    fine too.

    git diff -w can ignore all those things pretty easily.

    Using a bot is certainly sensible and sanity-preserving.
    I think it just needs a little tweaking.

    cheers, Joe

     \ /
      Last update: 2012-06-25 20:21    [W:0.021 / U:47.368 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site