lkml.org 
[lkml]   [2012]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: multi-second application stall in open()
On Mon, Jun 25, 2012 at 09:30:47AM -0400, Vivek Goyal wrote:
> In slice_expired() we can probably put a BUG_ON() which checks following.
>
> BUG_ON(RB_EMPTY_ROOT(&cfqq->sort_list) && (cfqq->queued[0] || cfqq->queued[1]));

Nit: Please use WARN_ON_ONCE() instead. Multi-sec stalls tend to be
better than panic. :)

--
tejun


\
 
 \ /
  Last update: 2012-06-25 20:21    [W:0.274 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site