lkml.org 
[lkml]   [2012]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/4] memcg: optimize memcg_get_hierarchical_limit
On Mon, Jun 25, 2012 at 06:52:25PM +0900, Kamezawa Hiroyuki wrote:
>(2012/06/25 17:44), Wanpeng Li wrote:
>> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
>>
>> Optimize memcg_get_hierarchical_limit to save cpu cycle.
>>
>> Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
>
>I can't understand the benefit of this patch to the real world...
>
>So, if you wrote the patch description as "clean up" rather than optimize,
>ok, I'll agree.
OK, I will change to "Cleanup". Thank you Kame.

Best Regards,
Wanpeng Li

>
>Thanks,
>-Kame
>
>> ---
>> mm/memcontrol.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index 2e81328..4520b57 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -3917,9 +3917,9 @@ static void memcg_get_hierarchical_limit(struct mem_cgroup *memcg,
>>
>> min_limit = res_counter_read_u64(&memcg->res, RES_LIMIT);
>> min_memsw_limit = res_counter_read_u64(&memcg->memsw, RES_LIMIT);
>> - cgroup = memcg->css.cgroup;
>> if (!memcg->use_hierarchy)
>> goto out;
>> + cgroup = memcg->css.cgroup;
>>
>> while (cgroup->parent) {
>> cgroup = cgroup->parent;
>>
>
>
>


\
 
 \ /
  Last update: 2012-06-25 13:21    [W:0.069 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site