[lkml]   [2012]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: deferring __fput()
    On 06/24, Oleg Nesterov wrote:
    > On 06/23, Al Viro wrote:
    > >
    > > What we ought to
    > > do instead of that is honestly keeping both the head of the (single-linked) list and
    > > pointer to pointer to its last element. Sure, that'll eat one more word in task_struct.
    > > And it doesn't matter, since we'll be able to kill something else in there - namely,
    > > ->scm_work_list.
    > Still it is better to not add the second pointer, task->task_works can
    > point to the last work, and last_work->next points to the first one.

    So. task_struct has the single "struct task_work *last_twork" pointer,
    task_work has ->next. I'll try to cleanup task_work_cancel() a bit, but
    this all doesn't look too complicated, see below. (untested, probably
    buggy, but hopefully close to correct).

    Or do you still think we need the 2nd pointer in task_struct?


    task_work_add(struct task_struct *task, struct task_work *twork, bool notify)
    unsigned long flags;
    struct task_work *last;
    int err = -ESRCH;

    if (notify)
    return -ENOTSUPP;
    * We must not insert the new work if the task has already passed
    * exit_task_work(). We rely on do_exit()->raw_spin_unlock_wait()
    * and check PF_EXITING under pi_lock.
    raw_spin_lock_irqsave(&task->pi_lock, flags);
    if (likely(!(task->flags & PF_EXITING))) {
    last = task->last_twork ?: twork;
    task->last_twork = twork;
    twork->next = last->next;
    last->next = twork;
    err = 0;
    raw_spin_unlock_irqrestore(&task->pi_lock, flags);

    /* test_and_set_bit() implies mb(), see tracehook_notify_resume(). */
    if (likely(!err) && notify)
    return err;

    struct task_work *
    task_work_cancel(struct task_struct *task, task_work_func_t func)
    unsigned long flags;
    struct task_work *last;
    struct task_work *twork;
    struct task_work *prev;

    raw_spin_lock_irqsave(&task->pi_lock, flags);
    last = twork = task->last_twork;
    if (!last)
    goto unlock;

    do {
    prev = twork;
    twork = twork->next;
    if (twork->func != func)

    prev->next = twork->next;
    if (twork == last) {
    if (prev == twork)
    prev = NULL;
    task->last_twork = prev;
    goto unlock;

    } while (twork != last);
    twork = NULL;

    raw_spin_unlock_irqrestore(&task->pi_lock, flags);

    return twork;

    void task_work_run(void)
    struct task_struct *task = current;
    struct task_work *last;
    struct task_work *twork;
    struct task_work *next;

    last = task->last_twork;
    task->last_twork = NULL;

    if (unlikely(!last))

    next = last->next;
    do {
    twork = next;
    next = twork->next;
    } while (twork != last);

     \ /
      Last update: 2012-06-24 21:01    [W:0.026 / U:2.320 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site