Messages in this thread | | | Date | Sat, 23 Jun 2012 18:13:28 +0800 | From | Wanpeng Li <> | Subject | Re: [PATCH 4/6] memcg: move recent_rotated and recent_scanned informations |
| |
On Sat, Jun 23, 2012 at 11:51:13AM +0200, Johannes Weiner wrote: >On Sat, Jun 23, 2012 at 02:17:39PM +0800, Wanpeng Li wrote: >> From: Wanpeng Li <liwp@linux.vnet.ibm.com> >> >> Move recent_rotated and recent_scanned prints next to inactive_anon, >> ative_anon, inactive_file, active_file, and unevictable prints to >> save developers' time. Since they have to go a long way(when cat memory.stat) >> to find recent_rotated and recent_scanned prints which has relationship >> with the memory cgroup we care. These prints are behind total_* which >> not just focus on the memory cgroup we care currently. > >The hierarchical stats are about that memcg, too. And I don't want to
Move recent_rotated and recent_scanned prints next to file lru lists just because the pageout code in vmscan.c keeps track of how many of the mem/swap backed and file backed pages are referenced, and the higher the rotated/scanned ratio, the more valuable that cache is. Move five lru lists and associated debug informations together can make things convenience. :-)
Regards, Wanpeng Li
>turn on debugging and then look for the extra information hiding in >the middle of regular stats.
| |