Messages in this thread | | | Date | Sat, 23 Jun 2012 08:13:13 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] printk: Add printk_flush() to force buffered text to console |
| |
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 21 Jun 2012 19:52:03 -0400 > Steven Rostedt <rostedt@goodmis.org> wrote: > > > But with the new printk() changes, text without a newline > > gets buffered and does not print out to the console at the > > location of the printk. > > uh, how about we fix that? The old behaviour was good, the > new behaviour is noxious.
Absolutely.
pr_flush() really seems to be a workaround.
> Please idenfity these "new printk() changes". Was the new > noxiousness an unavoidable effect of them?
Fundamentally:
e2ae715d66bf kmsg - kmsg_dump() use iterator to receive log buffer content c313af145b9b printk() - isolate KERN_CONT users from ordinary complete lines 3ce9a7c0ac28 printk() - restore prefix/timestamp printing for multi-newline strings 649e6ee33f73 printk() - restore timestamp printing at console output 5c5d5ca51abd printk() - do not merge continuation lines of different threads 7f3a781d6fd8 printk - fix compilation for CONFIG_PRINTK=n 5fc3249068c1 kmsg: use do_div() to divide 64bit integer e11fea92e13f kmsg: export printk records to the /dev/kmsg interface 7ff9554bb578 printk: convert byte-buffer to variable-length record buffer
Should we revert them or can they be fixed sanely? Kay seems to be busy with other things so I guess a revert is the best we can do. Greg, Kay?
Thanks,
Ingo
| |