Messages in this thread | | | Date | Fri, 22 Jun 2012 10:34:32 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH 01/17] mm: sl[au]b: Add knowledge of PFMEMALLOC reserve pages |
| |
On Thu, Jun 21, 2012 at 05:30:56PM -0400, Rik van Riel wrote: > On 06/20/2012 07:43 AM, Mel Gorman wrote: > > >+/* Clears ac->pfmemalloc if no slabs have pfmalloc set */ > >+static void check_ac_pfmemalloc(struct kmem_cache *cachep, > >+ struct array_cache *ac) > >+{ > > >+ pfmemalloc_active = false; > >+out: > >+ spin_unlock_irqrestore(&l3->list_lock, flags); > >+} > > The comment and the function do not seem to match. >
Well spotted. There used to be ac->pfmemalloc and obviously I failed to update the comment when it was removed.
> Otherwise, the patch looks reasonable.
Thanks.
-- Mel Gorman SUSE Labs
| |