lkml.org 
[lkml]   [2012]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tip/core/rcu 17/22] rcu: RCU_SAVE_DYNTICK code no longer ever dead
    Date
    From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>

    Before RCU had unified idle, the RCU_SAVE_DYNTICK leg of the switch
    statement in force_quiescent_state() was dead code for CONFIG_NO_HZ=n
    kernel builds. With unified idle, the code is never dead. This commit
    therefore removes the "if" statement designed to make gcc aware of when
    the code was and was not dead.

    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Reviewed-by: Josh Triplett <josh@joshtriplett.org>
    ---
    kernel/rcutree.c | 2 --
    1 files changed, 0 insertions(+), 2 deletions(-)

    diff --git a/kernel/rcutree.c b/kernel/rcutree.c
    index 68a9d8b..1b0e441 100644
    --- a/kernel/rcutree.c
    +++ b/kernel/rcutree.c
    @@ -1744,8 +1744,6 @@ static void force_quiescent_state(struct rcu_state *rsp, int relaxed)
    break; /* grace period idle or initializing, ignore. */

    case RCU_SAVE_DYNTICK:
    - if (RCU_SIGNAL_INIT != RCU_SAVE_DYNTICK)
    - break; /* So gcc recognizes the dead code. */

    raw_spin_unlock(&rnp->lock); /* irqs remain disabled */

    --
    1.7.8


    \
     
     \ /
      Last update: 2012-06-23 00:41    [W:0.044 / U:5.792 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site