Messages in this thread | | | Date | Fri, 22 Jun 2012 08:02:56 +0100 | From | "Jan Beulich" <> | Subject | Re: [PATCH] x86, cpufeature: Fix duplicate feature name "dts" |
| |
>>> On 21.06.12 at 18:28, "H. Peter Anvin" <hpa@linux.intel.com> wrote: > Good spotting, but I'm worried this is the wrong fix. > > This is a userspace ABI change, and the and we have used "dts" for debug > store (debug trace store?) for a very long tie, whereas digital thermal > sensor only has been used since 2010; another *major* question is which > of these is more likely to be of interest to userspace. > > Jan, do you have any feeling on this?
Now that you already figured that there is user space code depending on the current (questionable) string, I don't think it matters much - I would have preferred to correct the string to match the CPUID documentation (albeit I seem to recall that early on the bit was indeed named DTS in the doc).
Wouldn't it be helpful if mkcapflags.pl detected duplicates?
Jan
| |