lkml.org 
[lkml]   [2012]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] mm: clear pages_scanned only if draining a pcp adds pages to the buddy allocator again
    On Fri, Jun 22, 2012 at 4:19 PM, Andrew Morton
    <akpm@linux-foundation.org> wrote:
    > On Thu, 14 Jun 2012 12:16:10 -0400
    > kosaki.motohiro@gmail.com wrote:
    >
    >> commit 2ff754fa8f (mm: clear pages_scanned only if draining a pcp adds pages
    >> to the buddy allocator again) fixed one free_pcppages_bulk() misuse. But two
    >> another miuse still exist.
    >
    > This changelog is irritating.  One can understand it a bit if one
    > happens to have a git repo handy (and why do this to the reader?), but
    > the changelog for 2ff754fa8f indicates that the patch might fix a
    > livelock.  Is that true of this patch?  Who knows...

    The code in this simple patch speak the right usage, isn't it? And yes,
    this patch also fixes a possibility of live lock. (but i haven't seen actual
    live lock cause from this mistake)

    When anyone find a function misuse and fixes it, He/She should confirm other
    callsite and should all of mistake too. Otherwise we observe the same issue
    sooner of later.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-06-22 23:41    [W:0.029 / U:32.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site