lkml.org 
[lkml]   [2012]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] perf, x86: Improve debug output in check_hw_exists()
On 22.06.12 17:53:47, Peter Zijlstra wrote:
> My gcc wants me to add the below to avoid used uninitialized warns:
>
> ---
> --- a/arch/x86/kernel/cpu/perf_event.c
> +++ b/arch/x86/kernel/cpu/perf_event.c
> @@ -211,8 +211,9 @@ static bool check_hw_exists(void)
> * that don't trap on the MSR access and always return 0s.
> */
> val = 0xabcdUL;
> - ret = wrmsrl_safe(x86_pmu_event_addr(0), val);
> - ret |= rdmsrl_safe(x86_pmu_event_addr(0), &val_new);
> + reg = x86_pmu_event_addr(0);
> + ret = wrmsrl_safe(reg, val);
> + ret |= rdmsrl_safe(reg, &val_new);

Yes, this is correct. It fixes also correct reporting of reg if it
fails here.

I wonder why my gcc this didn't report, its 4.4.5.

Thanks,

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center



\
 
 \ /
  Last update: 2012-06-22 19:21    [W:0.080 / U:2.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site