Messages in this thread | | | From | "Kim, Milo" <> | Subject | RE: [PATCH 1/1 v4] leds: Add LED driver for lm3556 chip | Date | Fri, 22 Jun 2012 01:05:11 +0000 |
| |
> LM3556 : > The LM3556 is a 4 MHz fixed-frequency synchronous boost > converter plus 1.5A constant current driver for a high-current white > LED.
Overall, it looks pretty good to me, especially core functionality of lm3556 is well supported and it's easy to use.
Just one thing to be better, I would suggest to use module_i2c_driver() rather than lm3556_init/lm3556_exit for code simplicity.
> +static int __init lm3556_init(void) > +{ > + return i2c_add_driver(&lm3556_i2c_driver); > +} > + > +static void __exit lm3556_exit(void) > +{ > + i2c_del_driver(&lm3556_i2c_driver); > +} > + > +module_init(lm3556_init); > +module_exit(lm3556_exit);
module_i2c_driver(lm3556_i2c_driver);
Thanks, Milo -
| |