Messages in this thread | | | Date | Thu, 21 Jun 2012 18:43:29 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 10/17] netvm: Allow skb allocation to use PFMEMALLOC reserves |
| |
> > This is mostly used by nic to refil their RX skb pool. You add the > > __GFP_MEMALLOC to the allocation to rise the change of a successfull refill > > for the swap case. > > A few drivers use build_skb() to create the skb. __netdev_alloc_skb() > > shouldn't be affected since the allocation happens with GFP_ATOMIC. Looking at > > TG3 it uses build_skb() and get_pages() / kmalloc(). Shouldn't this be some > > considered? > > Please look at net-next, this was changed recently. > > In fact most RX allocations are done using netdev_alloc_frag(), because > its called from __netdev_alloc_skb()
Argh, this is what I meant more or less. I got the flag magic wrong so I assumed that this is only called without GFP_ATOMIC but it is not. Thanks for the hint.
> So tg3 is not anymore the exception, but the norm.
Sebastian
| |