lkml.org 
[lkml]   [2012]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v7 01/10] KVM: MMU: return bool in __rmap_write_protect
    The reture value of __rmap_write_protect is either 1 or 0, use
    true/false instead of these

    Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
    ---
    arch/x86/kvm/mmu.c | 13 +++++++------
    1 files changed, 7 insertions(+), 6 deletions(-)

    diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
    index 24dd43d..fad5c91 100644
    --- a/arch/x86/kvm/mmu.c
    +++ b/arch/x86/kvm/mmu.c
    @@ -1051,11 +1051,12 @@ static void drop_spte(struct kvm *kvm, u64 *sptep)
    rmap_remove(kvm, sptep);
    }

    -static int __rmap_write_protect(struct kvm *kvm, unsigned long *rmapp, int level)
    +static bool
    +__rmap_write_protect(struct kvm *kvm, unsigned long *rmapp, int level)
    {
    u64 *sptep;
    struct rmap_iterator iter;
    - int write_protected = 0;
    + bool write_protected = false;

    for (sptep = rmap_get_first(*rmapp, &iter); sptep;) {
    BUG_ON(!(*sptep & PT_PRESENT_MASK));
    @@ -1076,7 +1077,7 @@ static int __rmap_write_protect(struct kvm *kvm, unsigned long *rmapp, int level
    sptep = rmap_get_first(*rmapp, &iter);
    }

    - write_protected = 1;
    + write_protected = true;
    }

    return write_protected;
    @@ -1107,12 +1108,12 @@ void kvm_mmu_write_protect_pt_masked(struct kvm *kvm,
    }
    }

    -static int rmap_write_protect(struct kvm *kvm, u64 gfn)
    +static bool rmap_write_protect(struct kvm *kvm, u64 gfn)
    {
    struct kvm_memory_slot *slot;
    unsigned long *rmapp;
    int i;
    - int write_protected = 0;
    + bool write_protected = false;

    slot = gfn_to_memslot(kvm, gfn);

    @@ -1703,7 +1704,7 @@ static void mmu_sync_children(struct kvm_vcpu *vcpu,

    kvm_mmu_pages_init(parent, &parents, &pages);
    while (mmu_unsync_walk(parent, &pages)) {
    - int protected = 0;
    + bool protected = false;

    for_each_sp(pages, sp, parents, i)
    protected |= rmap_write_protect(vcpu->kvm, sp->gfn);
    --
    1.7.7.6


    \
     
     \ /
      Last update: 2012-06-20 10:41    [W:0.071 / U:30.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site